-
Notifications
You must be signed in to change notification settings - Fork 2.3k
txtar: add UTF-8 test case in TestParse #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR (HEAD: c276b0b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712980. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from Michael Matloob: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
This PR (HEAD: 920f684) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712980. Important tips:
|
|
Message from Michael Matloob: Patch Set 3: Code-Review+2 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from t hepudds: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from t hepudds: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-30T19:22:45Z","revision":"f1081026aff0c528379d43e1644d31679b7d058e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from t hepudds: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
|
Message from Michael Matloob: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/712980. |
Adds a new test case for the txtar package to verify that:
Parse correctly handles UTF-8 characters in file contents.
Leading comment lines are preserved properly.
This improves test coverage for non-ASCII content and ensures
comment parsing works as expected.